Xch/test new nbgl #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiz Scan Summary
|
sgliner-ledger
previously approved these changes
Mar 22, 2024
| reject_confirmation); | ||
| nbgl_useCaseReviewStreamingStart(TYPE_OPERATION, | ||
| &C_stax_app_eos_64px, | ||
| "Review operation", |
There was a problem hiding this comment.
If we use TYPE_OPERATION can't both string be defined in the SDK?
Maybe default behaviour could be to have them set to NULL, and if the developer want to customize he could still set it ?
| pair.value = review_title; | ||
| return &pair; | ||
| } else { | ||
| return get_single_action_review_pair(index -1); |
|
|
||
| void ui_display_single_action_sign_flow(void) { |
There was a problem hiding this comment.
Looking at the code, I find it not so easy to follow functions to understand what the final screens will look like. Maybe we should try to find a descriptive way to comment the screens, such as what used to be done on bagl ? 🤔
| pairList.startIndex = 0; | ||
|
|
||
| nbgl_useCaseStaticReview(&pairList, &infoLongPress, "Reject transaction", review_choice); | ||
| } | ||
| if (txProcessingCtx.currentActionNumer == 1) { |
xchapron-ledger
force-pushed
the
xch/test-new-nbgl
branch
from
199f340
to
102fdca
Compare
|
Closing, because integrated, with latest NBGL fetures/API in #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo of LedgerHQ/ledger-secure-sdk#576